romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-07-16 01:47:16 +03:00
Code Issues Projects Releases Packages Wiki Activity

cw-out: add assert for data->conn

Browse source 
Instead of checking it runtime. CodeSonar pointed out that if it
actually CAN legitimately be NULL here, then we need to do more checks
for it...

Closes #18440
This commit is contained in:
Daniel Stenberg 2025-08-31 13:33:05 +02:00
parent 84c92f7113
commit 5256ce229e
No known key found for this signature in database
GPG key ID: 5CC908FDB71E12C2
1 changed files with 8 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

15
lib/cw-out.c
View file

@ -196,16 +196,17 @@ static void cw_get_writefunc(struct Curl_easy *data, cw_out_type otype,
}
static CURLcode cw_out_cb_write(struct cw_out_ctx *ctx,
struct Curl_easy *data,
curl_write_callback wcb,
void *wcb_data,
cw_out_type otype,
const char *buf, size_t blen,
size_t *pnwritten)
struct Curl_easy *data,
curl_write_callback wcb,
void *wcb_data,
cw_out_type otype,
const char *buf, size_t blen,
size_t *pnwritten)
{
size_t nwritten;
CURLcode result;
DEBUGASSERT(data->conn);
*pnwritten = 0;
Curl_set_in_callback(data, TRUE);
nwritten = wcb((char *)CURL_UNCONST(buf), 1, blen, wcb_data);
@ -214,7 +215,7 @@ static CURLcode cw_out_cb_write(struct cw_out_ctx *ctx,
blen, (otype == CW_OUT_HDS) ? "header" : "body",
nwritten);
if(CURL_WRITEFUNC_PAUSE == nwritten) {
if(data->conn && data->conn->handler->flags & PROTOPT_NONETWORK) {
if(data->conn->handler->flags & PROTOPT_NONETWORK) {
/* Protocols that work without network cannot be paused. This is
actually only FILE:// just now, and it cannot pause since the
transfer is not done using the "normal" procedure. */