From 5196abad7313dbdfb861ab54dd57d78c81465867 Mon Sep 17 00:00:00 2001 From: Dan Fandrich Date: Mon, 15 Dec 2025 23:32:59 -0800 Subject: [PATCH] lib: create unitprotos.h in the builddir, not srcdir The make rule confused automake by changing directories before creating the file, causing unitprotos.h to be created in the srcdir instead of the builddir. This results in a stale file and confusing compile errors in out-of-tree builds. Fixes #19966 Closes #19993 --- lib/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Makefile.am b/lib/Makefile.am index 2645872ebf..813b2224eb 100644 --- a/lib/Makefile.am +++ b/lib/Makefile.am @@ -165,7 +165,7 @@ UNITV_ = $(UNITV_0) # UNITPROTOS depends on every C file in the lib/ dir $(UNITPROTOS): $(CSOURCES) - $(UNIT_V)(cd $(srcdir) && @PERL@ ../scripts/extract-unit-protos $(CSOURCES) > $(top_builddir)/lib/$(UNITPROTOS)) + $(UNIT_V)(cd $(srcdir) && @PERL@ ../scripts/extract-unit-protos $(CSOURCES)) > $(top_builddir)/lib/$(UNITPROTOS) # disable the tests that are mostly causing false positives TIDYFLAGS := -checks=-clang-analyzer-security.insecureAPI.bzero,-clang-analyzer-security.insecureAPI.strcpy,-clang-analyzer-optin.performance.Padding,-clang-analyzer-security.ArrayBound,-clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling -quiet