libssh: react on errors from ssh_scp_read

Reported in Joshua's sarif data

Closes #18616
This commit is contained in:
Daniel Stenberg 2025-09-19 13:35:23 +02:00
parent b2356a3197
commit 4f5528675a
No known key found for this signature in database
GPG key ID: 5CC908FDB71E12C2

View file

@ -2889,7 +2889,7 @@ static CURLcode scp_recv(struct Curl_easy *data, int sockindex,
{
struct connectdata *conn = data->conn;
struct ssh_conn *sshc = Curl_conn_meta_get(conn, CURL_META_SSH_CONN);
ssize_t nread;
int nread;
(void)sockindex; /* we only support SCP on the fixed known primary socket */
*pnread = 0;
@ -2899,7 +2899,8 @@ static CURLcode scp_recv(struct Curl_easy *data, int sockindex,
/* libssh returns int */
nread = ssh_scp_read(sshc->scp_session, mem, len);
if(nread == SSH_ERROR)
return CURLE_SSH;
#if 0
/* The following code is misleading, mostly added as wishful thinking
* that libssh at some point will implement non-blocking ssh_scp_write/read.