romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-05-18 20:06:20 +03:00
Code Issues Projects Releases Packages Wiki Activity

HTTP/2: strip TE request header

Browse source 
The TE request header field is invalid in HTTP/2. Since clients may not
know in advance if a connection negotiates HTTP/2, automatically strip
such a header when h2 is in play.

Add test_01_10 to verify.

Reported-by: Jiri Stary
Fixes #15941
Closes #15943
This commit is contained in:
Stefan Eissing 2025-01-08 16:34:38 +01:00 • committed by Daniel Stenberg
parent 515a21f350
commit 4e15605896
No known key found for this signature in database
GPG key ID: 5CC908FDB71E12C2
2 changed files with 12 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/http.c
View file

@ -4121,7 +4121,9 @@ struct name_const {
size_t namelen;
};
/* keep them sorted by length! */
static struct name_const H2_NON_FIELD[] = {
{ STRCONST("TE") },
{ STRCONST("Host") },
{ STRCONST("Upgrade") },
{ STRCONST("Connection") },

10
tests/http/test_01_basic.py
View file

@ -139,3 +139,13 @@ class TestBasic:
assert r.response['status'] == 200, f'{r.responsw}'
assert r.response['protocol'] == 'HTTP/2', f'{r.response}'
assert r.json['server'] == env.domain1
# http: strip TE header in HTTP/2 requests
def test_01_10_te_strip(self, env: Env, httpd):
curl = CurlClient(env=env)
url = f'https://{env.authority_for(env.domain1, "h2")}/data.json'
r = curl.http_get(url=url, extra_args=['--http2', '-H', 'TE: gzip'])
r.check_exit_code(0)
assert len(r.responses) == 1, f'{r.responses}'
assert r.responses[0]['status'] == 200, f'{r.responses[1]}'
assert r.responses[0]['protocol'] == 'HTTP/2', f'{r.responses[1]}'