romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-07-23 18:17:15 +03:00
Code Issues Projects Releases Packages Wiki Activity

ftp: Expression 'ftpc->wait_data_conn' is always false

Browse source 
Fixes warning detected by PVS-Studio
Fixes #4374
This commit is contained in:
Daniel Stenberg 2019-09-19 09:18:26 +02:00
parent a50c3d7fa0
commit 49f3117a23
No known key found for this signature in database
GPG key ID: 5CC908FDB71E12C2
1 changed files with 2 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

9
lib/ftp.c
View file

@ -3570,13 +3570,8 @@ static CURLcode ftp_do_more(struct connectdata *conn, int *completep)
return result;
result = ftp_multi_statemach(conn, &complete);
if(ftpc->wait_data_conn)
/* if we reach the end of the FTP state machine here, *complete will be
TRUE but so is ftpc->wait_data_conn, which says we need to wait for
the data connection and therefore we're not actually complete */
*completep = 0;
else
*completep = (int)complete;
/* ftpc->wait_data_conn is always false here */
*completep = (int)complete;
}
else {
/* download */