romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-08-14 23:33:39 +03:00
Code Issues Projects Releases Packages Wiki Activity

setopt: check CURLOPT_TFTP_BLKSIZE range on set

Browse source 
... instead of later when the transfer is about to happen.

Closes #12374
This commit is contained in:
Daniel Stenberg 2023-11-21 17:34:30 +01:00
parent 84338c4de2
commit 49c413cce2
No known key found for this signature in database
GPG key ID: 5CC908FDB71E12C2
3 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

8
lib/tftp.c
View file

@ -70,8 +70,6 @@
/* RFC2348 allows the block size to be negotiated */
#define TFTP_BLKSIZE_DEFAULT 512
#define TFTP_BLKSIZE_MIN 8
#define TFTP_BLKSIZE_MAX 65464
#define TFTP_OPTION_BLKSIZE "blksize"
/* from RFC2349: */
@ -978,11 +976,9 @@ static CURLcode tftp_connect(struct Curl_easy *data, bool *done)
return CURLE_OUT_OF_MEMORY;
/* alloc pkt buffers based on specified blksize */
if(data->set.tftp_blksize) {
if(data->set.tftp_blksize)
/* range checked when set */
blksize = (int)data->set.tftp_blksize;
if(blksize > TFTP_BLKSIZE_MAX || blksize < TFTP_BLKSIZE_MIN)
return CURLE_TFTP_ILLEGAL;
}
need_blksize = blksize;
/* default size is the fallback when no OACK is received */