GHA: fix zizmor 1.10.0 warnings, update names

Job `name:` now mandatory in zizmor.

Also:
- enclose `name:` values in single-quotes, for uniformity.
- drop `name: checkout` where set, for uniformity.
- dist: also install with cmake.
- dist: replace `make` with `cmake --build` for cmake.
  (to make this make-tool agnostic)
- appveyor-status: double-quote shell arguments.
- tweak existing names to be shorter, to sync terms and style across
  jobs and steps.

Ref: https://github.com/zizmorcore/zizmor/releases/tag/v1.10.0

Closes #17773
This commit is contained in:
Viktor Szakats 2025-06-28 20:22:11 +02:00
parent a3787f98ac
commit 48d3407d7c
No known key found for this signature in database
GPG key ID: B5ABD165E2AEF201
15 changed files with 147 additions and 129 deletions

View file

@ -4,7 +4,7 @@
# This workflow contains checks at the source code level only.
name: Source
name: 'Source'
'on':
push:
@ -33,25 +33,25 @@ permissions: {}
jobs:
checksrc:
name: 'checksrc'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
with:
persist-credentials: false
name: checkout
- name: check
- name: 'check'
run: scripts/checksrc-all.sh
codespell-cmakelint-pytype-ruff:
name: 'codespell, cmakelint, pytype, ruff'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
with:
persist-credentials: false
name: checkout
- name: install
- name: 'install'
env:
DEBIAN_FRONTEND: noninteractive
run: |
@ -65,7 +65,7 @@ jobs:
python3-websockets python3-pytest python3-filelock python3-pytest-xdist
python3 -m pip install --break-system-packages cmakelang==0.6.13 pytype==2024.10.11 ruff==0.11.9
- name: spellcheck
- name: 'spellcheck'
run: |
codespell \
--skip scripts/mk-ca-bundle.pl \
@ -74,36 +74,36 @@ jobs:
-I .github/scripts/codespell-ignore.txt \
CMake include m4 scripts src lib
- name: cmakelint
- name: 'cmakelint'
run: scripts/cmakelint.sh
- name: pytype
- name: 'pytype'
run: find . -name '*.py' -exec pytype -j auto -k {} +
- name: ruff
- name: 'ruff'
run: scripts/pythonlint.sh
reuse:
name: 'REUSE'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
with:
persist-credentials: false
name: checkout
- name: REUSE Compliance Check
- name: 'check'
uses: fsfe/reuse-action@bb774aa972c2a89ff34781233d275075cbddf542 # v5
complexity:
name: 'complexity'
runs-on: ubuntu-latest
timeout-minutes: 3
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
with:
persist-credentials: false
name: checkout
- name: install pmccabe
- name: 'install pmccabe'
run: |
sudo rm -f /etc/apt/sources.list.d/microsoft-prod.list
sudo apt-get -o Dpkg::Use-Pty=0 update
@ -111,53 +111,52 @@ jobs:
sudo apt-get -o Dpkg::Use-Pty=0 install \
pmccabe
- name: check complexity scores
- name: 'check scores'
run: ./scripts/top-complexity
miscchecks:
name: 'misc checks'
runs-on: ubuntu-latest
timeout-minutes: 5
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
with:
persist-credentials: false
name: checkout
- name: shellcheck
- name: 'shellcheck'
run: |
shellcheck --version
.github/scripts/shellcheck.sh
- name: spacecheck
- name: 'spacecheck'
run: .github/scripts/spacecheck.pl
- name: yamlcheck
- name: 'yamlcheck'
run: .github/scripts/yamlcheck.sh
# we allow some extra in source code
- name: badwords
- name: 'badwords'
run: |
# shellcheck disable=SC2046
grep -Ev '(\\bwill| url | dir )' .github/scripts/badwords.txt | \
.github/scripts/badwords.pl $(git ls-files -- src lib include)
cicheck:
name: CI analysis
name: 'CI'
runs-on: macos-latest
timeout-minutes: 1
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
with:
persist-credentials: false
name: checkout
- name: install prereqs
- name: 'install prereqs'
run: brew install shellcheck zizmor
- name: zizmor GHA
- name: 'zizmor GHA'
run: zizmor --pedantic .github/workflows/*.yml
- name: shellcheck
- name: 'shellcheck GHA'
run: |
shellcheck --version
.github/scripts/shellcheck-ci.sh