romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-08-25 10:53:37 +03:00
Code Issues Projects Releases Packages Wiki Activity

Avoid typecasting a signed char to an int when using is*() functions, as that

Browse source 
could very well cause a negate number get passed in and thus cause reading
outside of the array usually used for this purpose.

We avoid this by using the uppercase macro versions introduced just now that
does some extra crazy typecasts to avoid byte codes > 127 to cause negative
int values.
This commit is contained in:
Daniel Stenberg 2006-10-17 21:32:56 +00:00
parent 930f9bd534
commit 44d84ac164
17 changed files with 81 additions and 59 deletions
Download patch file Download diff file Expand all files Collapse all files

10
lib/transfer.c
View file

@ -762,7 +762,7 @@ CURLcode Curl_readwrite(struct connectdata *conn,
/* Find the first non-space letter */
for(start=k->p+13;
*start && isspace((int)*start);
*start && ISSPACE(*start);
start++)
; /* empty loop */
@ -772,7 +772,7 @@ CURLcode Curl_readwrite(struct connectdata *conn,
if(end) {
/* skip all trailing space letters */
for(; isspace((int)*end) && (end > start); end--)
for(; ISSPACE(*end) && (end > start); end--)
; /* empty loop */
/* get length of the type */
@ -877,7 +877,7 @@ CURLcode Curl_readwrite(struct connectdata *conn,
/* Find the first non-space letter */
for(start=k->p+17;
*start && isspace((int)*start);
*start && ISSPACE(*start);
start++)
; /* empty loop */
@ -957,7 +957,7 @@ CURLcode Curl_readwrite(struct connectdata *conn,
/* Skip spaces and tabs. We do this to support multiple
white spaces after the "Location:" keyword. */
while(*start && isspace((int)*start ))
while(*start && ISSPACE(*start ))
start++;
/* Scan through the string from the end to find the last
@ -966,7 +966,7 @@ CURLcode Curl_readwrite(struct connectdata *conn,
there. This logic strips off trailing whitespace, but keeps
any embedded whitespace. */
ptr = k->end_ptr-1;
while((ptr>=start) && isspace((int)*ptr))
while((ptr>=start) && ISSPACE(*ptr))
ptr--;
ptr++;