romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-07-22 21:27:15 +03:00
Code Issues Projects Releases Packages Wiki Activity

cmake: fix curl_add_clang_tidy_test_target when no -D option

Browse source 
Fix `curl_add_clang_tidy_test_target` generating an invalid option for
`clang-tidy` if the tested target has no custom macro definition.

Current build doesn't hit this case, but a pending PR does.

Fixing:
```
[...] -Ilib -Itests/client -DCURL_HIDDEN_SYMBOLS -DHAVE_CONFIG_H -D_definitions_t-NOTFOUND
```
error: ISO C99 requires whitespace after the macro name [clang-diagnostic-c99-extensions,-warnings-as-errors]

Cherry-picked from #17768
Closes #17813
This commit is contained in:
Viktor Szakats 2025-06-28 03:38:35 +02:00
parent b2c9e5ea10
commit 42fdc65a98
No known key found for this signature in database
GPG key ID: B5ABD165E2AEF201
1 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
CMake/Macros.cmake
View file

@ -141,6 +141,9 @@ macro(curl_add_clang_tidy_test_target _target_clang_tidy _target)
# Collect macro definitions applying to the target
get_directory_property(_definitions_d COMPILE_DEFINITIONS)
get_target_property(_definitions_t ${_target} COMPILE_DEFINITIONS)
if(NOT _definitions_t)
unset(_definitions_t)
endif()
set(_definitions "${_definitions_l};${_definitions_d};${_definitions_t}")
list(REMOVE_ITEM _definitions "")