romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-06-21 01:15:37 +03:00
Code Issues Projects Releases Packages Wiki Activity

tool_operate: fix scanbuild compiler warning

Browse source 
Prior to this change Azure CI scanbuild warned of a potential NULL
pointer string passed to strtol when CURLDEBUG enabled, even though the
way the code was written it wouldn't have happened.

Bug: 5479d991 (r101159711)
Reported-by: Marcel Raad

Closes https://github.com/curl/curl/pull/10559
This commit is contained in:
Jay Satiro 2023-02-18 16:06:11 -05:00
parent cab040248d
commit 41dfb7f516
1 changed files with 9 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

17
src/tool_operate.c
View file

@ -1301,15 +1301,16 @@ static CURLcode single_transfer(struct GlobalConfig *global,
my_setopt(curl, CURLOPT_SEEKDATA, input);
my_setopt(curl, CURLOPT_SEEKFUNCTION, tool_seek_cb);
#ifdef CURLDEBUG
if(getenv("CURL_BUFFERSIZE")) {
long size = strtol(getenv("CURL_BUFFERSIZE"), NULL, 10);
if(size)
my_setopt(curl, CURLOPT_BUFFERSIZE, size);
}
else
#endif
{
#ifdef CURLDEBUG
char *env = getenv("CURL_BUFFERSIZE");
if(env) {
long size = strtol(env, NULL, 10);
if(size)
my_setopt(curl, CURLOPT_BUFFERSIZE, size);
}
else
#endif
if(config->recvpersecond &&
(config->recvpersecond < BUFFER_SIZE))
/* use a smaller sized buffer for better sleeps */