romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-06-04 09:04:20 +03:00
Code Issues Projects Releases Packages Wiki Activity

dynbuf: return NULL when there's no buffer length

Browse source 
... as returning a "" is not a good idea as the string is supposed to be
allocated and returning a const string will cause issues.

Reported-by: Brian Carpenter
Follow-up to ed35d6590e
Closes #5405
This commit is contained in:
Daniel Stenberg 2020-05-17 19:47:45 +02:00
parent 2c598cc778
commit 3df42ca949
No known key found for this signature in database
GPG key ID: 5CC908FDB71E12C2
2 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

4
lib/dynbuf.c
View file

@ -201,7 +201,7 @@ char *Curl_dyn_ptr(const struct dynbuf *s)
DEBUGASSERT(s);
DEBUGASSERT(s->init == DYNINIT);
DEBUGASSERT(!s->leng || s->bufr);
return s->leng ? s->bufr : (char *)"";
return s->bufr;
}
/*
@ -212,7 +212,7 @@ unsigned char *Curl_dyn_uptr(const struct dynbuf *s)
DEBUGASSERT(s);
DEBUGASSERT(s->init == DYNINIT);
DEBUGASSERT(!s->leng || s->bufr);
return s->leng ? (unsigned char *)s->bufr : (unsigned char *)"";
return (unsigned char *)s->bufr;
}
/*