lib: move request specific allocations to the request struct

To make it clearer that they are ephemeral.

Closes #21301
This commit is contained in:
Daniel Stenberg 2026-04-13 19:38:16 +02:00
parent 7a349b5eed
commit 3512b673dd
No known key found for this signature in database
GPG key ID: 5CC908FDB71E12C2
13 changed files with 37 additions and 43 deletions

View file

@ -453,9 +453,9 @@ static CURLcode rtsp_do(struct Curl_easy *data, bool *done)
goto out;
#ifndef CURL_DISABLE_PROXY
p_proxyuserpwd = data->state.aptr.proxyuserpwd;
p_proxyuserpwd = data->req.proxyuserpwd;
#endif
p_userpwd = data->state.aptr.userpwd;
p_userpwd = data->req.userpwd;
/* Referrer */
curlx_safefree(data->state.aptr.ref);
@ -538,12 +538,6 @@ static CURLcode rtsp_do(struct Curl_easy *data, bool *done)
p_proxyuserpwd ? p_proxyuserpwd : "",
p_userpwd ? p_userpwd : "");
/*
* Free userpwd now --- cannot reuse this for Negotiate and possibly NTLM
* with basic and digest, it will be freed anyway by the next request
*/
curlx_safefree(data->state.aptr.userpwd);
if(result)
goto out;