tidy-up: miscellaneous

- apply more clang-format.
- lib/version: use `CURL_ARRAYSIZE()`.
- INSTALL-CMAKE.md: sync-up an option description with others.
- examples: delete unused main args.
- examples/ftpgetinfo: document `_CRT_SECURE_NO_WARNINGS` symbol.
- delete remaining stray duplicate lines.
- acinclude.m4: drop an unnecessary x-hack.
- vtls/mbedtls: join a URL split into two lines.
- src/tool_cb_see: add parentheses around macro expressions.
- src/tool_operate: move literals to the right side of comparisons.
- libtests: sync up fopen/fstat error messages between tests.
- curl_setup.h: replace `if ! defined __LP64` with `ifndef __LP64`.
  I assume it makes no difference on Tandem systems, as the latter form
  is already used in `include/curl/system.h`.

Closes #20018
This commit is contained in:
Viktor Szakats 2025-12-12 20:51:52 +01:00
parent cd9da30e76
commit 308c347c8b
No known key found for this signature in database
GPG key ID: B5ABD165E2AEF201
53 changed files with 988 additions and 1005 deletions

View file

@ -229,9 +229,9 @@ static const mbedtls_x509_crt_profile mbedtls_x509_crt_profile_fr = {
1024, /* RSA min key len */
};
/* See https://web.archive.org/web/20200921194007/tls.mbed.org/discussions/
generic/howto-determine-exact-buffer-len-for-mbedtls_pk_write_pubkey_der
*/
/* See:
* https://web.archive.org/web/20200921194007/tls.mbed.org/discussions/generic/howto-determine-exact-buffer-len-for-mbedtls_pk_write_pubkey_der
*/
#define RSA_PUB_DER_MAX_BYTES (38 + 2 * MBEDTLS_MPI_MAX_SIZE)
#define ECP_PUB_DER_MAX_BYTES (30 + 2 * MBEDTLS_ECP_MAX_BYTES)

View file

@ -1443,7 +1443,6 @@ fail:
return 1;
}
static CURLcode client_cert(struct Curl_easy *data,
SSL_CTX* ctx,
char *cert_file,
@ -3629,7 +3628,6 @@ static CURLcode ossl_init_ssl(struct ossl_ctx *octx,
alpns_requested, sess_reuse_cb);
}
static CURLcode ossl_init_method(struct Curl_cfilter *cf,
struct Curl_easy *data,
struct ssl_peer *peer,
@ -3828,7 +3826,7 @@ CURLcode Curl_ossl_ctx_init(struct ossl_ctx *octx,
OpenSSL supports processing "jumbo TLS record" (8 TLS records) in one go
for some algorithms, so match that here.
Experimentation shows that a slightly larger buffer is needed
to avoid short reads.
to avoid short reads.
However using a large buffer (8 packets) actually decreases performance.
4 packets is better.
@ -4669,7 +4667,6 @@ out:
}
#endif /* ! CURL_DISABLE_VERBOSE_STRINGS */
#ifdef USE_APPLE_SECTRUST
struct ossl_certs_ctx {
STACK_OF(X509) *sk;

View file

@ -70,8 +70,8 @@
#define SCH_DEV_SHOWBOOL(x) \
infof(data, "schannel: " #x " %s", (x) ? "TRUE" : "FALSE");
#else
#define SCH_DEV(x) do { } while(0)
#define SCH_DEV_SHOWBOOL(x) do { } while(0)
#define SCH_DEV(x) do {} while(0)
#define SCH_DEV_SHOWBOOL(x) do {} while(0)
#endif
/* Offered by mingw-w64 v8+. MS SDK 7.0A+. */

View file

@ -36,7 +36,6 @@
#include <wolfssl/options.h>
#include <wolfssl/version.h>
#if LIBWOLFSSL_VERSION_HEX < 0x03004006 /* wolfSSL 3.4.6 (2015) */
#error "wolfSSL version should be at least 3.4.6"
#endif

View file

@ -92,7 +92,6 @@
/* #define CURL_ASN1_CHARACTER_STRING 29 */
#define CURL_ASN1_BMP_STRING 30
#ifdef WANT_EXTRACT_CERTINFO
/* ASN.1 OID table entry. */
struct Curl_OID {