romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-07-28 04:53:08 +03:00
Code Issues Projects Releases Packages Wiki Activity

tidy-up: miscellaneous

Browse source 
- apply more clang-format.
- lib/version: use `CURL_ARRAYSIZE()`.
- INSTALL-CMAKE.md: sync-up an option description with others.
- examples: delete unused main args.
- examples/ftpgetinfo: document `_CRT_SECURE_NO_WARNINGS` symbol.
- delete remaining stray duplicate lines.
- acinclude.m4: drop an unnecessary x-hack.
- vtls/mbedtls: join a URL split into two lines.
- src/tool_cb_see: add parentheses around macro expressions.
- src/tool_operate: move literals to the right side of comparisons.
- libtests: sync up fopen/fstat error messages between tests.
- curl_setup.h: replace `if ! defined __LP64` with `ifndef __LP64`.
  I assume it makes no difference on Tandem systems, as the latter form
  is already used in `include/curl/system.h`.

Closes #20018
This commit is contained in:
Viktor Szakats 2025-12-12 20:51:52 +01:00
parent cd9da30e76
commit 308c347c8b
No known key found for this signature in database
GPG key ID: B5ABD165E2AEF201
53 changed files with 988 additions and 1005 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/conncache.c
View file

@ -69,7 +69,6 @@
} \
} while(0)
/* A list of connections to the same destination. */
struct cpool_bundle {
struct Curl_llist conns; /* connections in the bundle */
@ -167,7 +166,6 @@ static struct cpool_bundle *cpool_find_bundle(struct cpool *cpool,
conn->destination, strlen(conn->destination) + 1);
}
static void cpool_remove_bundle(struct cpool *cpool,
struct cpool_bundle *bundle)
{

4
lib/content_encoding.c
View file

@ -287,8 +287,10 @@ static const struct Curl_cwtype deflate_encoding = {
sizeof(struct zlib_writer)
};
/*
* Gzip handler.
*/
/* Gzip handler. */
static CURLcode gzip_do_init(struct Curl_easy *data,
struct Curl_cwriter *writer)
{

87
lib/curl_setup.h
View file

@ -162,7 +162,7 @@
/* ================================================================ */
/* Definition of preprocessor macros/symbols which modify compiler */
/* behavior or generated code characteristics must be done here, */
/* behavior or generated code characteristics must be done here, */
/* as appropriate, before any system header file is included. It is */
/* also possible to have them defined in the config file included */
/* before this point. As a result of all this we frown inclusion of */
@ -449,7 +449,7 @@
#include <assert.h>
#ifdef __TANDEM /* for ns*-tandem-nsk systems */
# if ! defined __LP64
# ifndef __LP64
# include <floss.h> /* FLOSS is only used for 32-bit builds. */
# endif
#endif
@ -783,7 +783,7 @@
* Definition of our NOP statement Object-like macro
*/
#ifndef Curl_nop_stmt
#define Curl_nop_stmt do { } while(0)
#define Curl_nop_stmt do {} while(0)
#endif
/*
@ -843,8 +843,8 @@
Therefore we specify it explicitly. https://github.com/curl/curl/pull/258
*/
#if defined(_WIN32) || defined(MSDOS)
#define FOPEN_READTEXT "rt"
#define FOPEN_WRITETEXT "wt"
#define FOPEN_READTEXT "rt"
#define FOPEN_WRITETEXT "wt"
#define FOPEN_APPENDTEXT "at"
#elif defined(__CYGWIN__)
/* Cygwin has specific behavior we need to address when _WIN32 is not defined.
@ -853,12 +853,12 @@ For write we want our output to have line endings of LF and be compatible with
other Cygwin utilities. For read we want to handle input that may have line
endings either CRLF or LF so 't' is appropriate.
*/
#define FOPEN_READTEXT "rt"
#define FOPEN_WRITETEXT "w"
#define FOPEN_READTEXT "rt"
#define FOPEN_WRITETEXT "w"
#define FOPEN_APPENDTEXT "a"
#else
#define FOPEN_READTEXT "r"
#define FOPEN_WRITETEXT "w"
#define FOPEN_READTEXT "r"
#define FOPEN_WRITETEXT "w"
#define FOPEN_APPENDTEXT "a"
#endif
@ -919,7 +919,10 @@ extern curl_calloc_callback Curl_ccalloc;
* This macro also assigns NULL to given pointer when free'd.
*/
#define Curl_safefree(ptr) \
do { curlx_free(ptr); (ptr) = NULL;} while(0)
do { \
curlx_free(ptr); \
(ptr) = NULL; \
} while(0)
#include <curl/curl.h> /* for CURL_EXTERN, mprintf.h */
@ -1002,15 +1005,13 @@ CURL_EXTERN RECV_TYPE_RETV curl_dbg_recv(RECV_TYPE_ARG1 sockfd,
/* FILE functions */
CURL_EXTERN int curl_dbg_fclose(FILE *file, int line, const char *source);
CURL_EXTERN ALLOC_FUNC
FILE *curl_dbg_fopen(const char *file, const char *mode,
int line, const char *source);
CURL_EXTERN ALLOC_FUNC
FILE *curl_dbg_freopen(const char *file, const char *mode, FILE *fh,
int line, const char *source);
CURL_EXTERN ALLOC_FUNC
FILE *curl_dbg_fdopen(int filedes, const char *mode,
int line, const char *source);
CURL_EXTERN ALLOC_FUNC FILE *curl_dbg_fopen(const char *file, const char *mode,
int line, const char *source);
CURL_EXTERN ALLOC_FUNC FILE *curl_dbg_freopen(const char *file,
const char *mode, FILE *fh,
int line, const char *source);
CURL_EXTERN ALLOC_FUNC FILE *curl_dbg_fdopen(int filedes, const char *mode,
int line, const char *source);
#define sclose(sockfd) curl_dbg_sclose(sockfd, __LINE__, __FILE__)
#define fake_sclose(sockfd) curl_dbg_mark_sclose(sockfd, __LINE__, __FILE__)
@ -1059,47 +1060,47 @@ CURL_EXTERN ALLOC_FUNC
#ifdef CURLDEBUG
#define curlx_strdup(ptr) curl_dbg_strdup(ptr, __LINE__, __FILE__)
#define curlx_malloc(size) curl_dbg_malloc(size, __LINE__, __FILE__)
#define curlx_calloc(nbelem,size) \
curl_dbg_calloc(nbelem, size, __LINE__, __FILE__)
#define curlx_realloc(ptr,size) \
curl_dbg_realloc(ptr, size, __LINE__, __FILE__)
#define curlx_free(ptr) curl_dbg_free(ptr, __LINE__, __FILE__)
#define curlx_strdup(ptr) curl_dbg_strdup(ptr, __LINE__, __FILE__)
#define curlx_malloc(size) curl_dbg_malloc(size, __LINE__, __FILE__)
#define curlx_calloc(nbelem, size) \
curl_dbg_calloc(nbelem, size, __LINE__, __FILE__)
#define curlx_realloc(ptr, size) \
curl_dbg_realloc(ptr, size, __LINE__, __FILE__)
#define curlx_free(ptr) curl_dbg_free(ptr, __LINE__, __FILE__)
#ifdef _WIN32
#ifdef UNICODE
#define curlx_tcsdup(ptr) curl_dbg_wcsdup(ptr, __LINE__, __FILE__)
#define curlx_tcsdup(ptr) curl_dbg_wcsdup(ptr, __LINE__, __FILE__)
#else
#define curlx_tcsdup(ptr) curlx_strdup(ptr)
#define curlx_tcsdup(ptr) curlx_strdup(ptr)
#endif
#endif /* _WIN32 */
#else /* !CURLDEBUG */
#ifdef BUILDING_LIBCURL
#define curlx_strdup(ptr) Curl_cstrdup(ptr)
#define curlx_malloc(size) Curl_cmalloc(size)
#define curlx_calloc(nbelem,size) Curl_ccalloc(nbelem, size)
#define curlx_realloc(ptr,size) Curl_crealloc(ptr, size)
#define curlx_free(ptr) Curl_cfree(ptr)
#define curlx_strdup(ptr) Curl_cstrdup(ptr)
#define curlx_malloc(size) Curl_cmalloc(size)
#define curlx_calloc(nbelem, size) Curl_ccalloc(nbelem, size)
#define curlx_realloc(ptr, size) Curl_crealloc(ptr, size)
#define curlx_free(ptr) Curl_cfree(ptr)
#else /* !BUILDING_LIBCURL */
#ifdef _WIN32
#define curlx_strdup(ptr) _strdup(ptr)
#define curlx_strdup(ptr) _strdup(ptr)
#else
#define curlx_strdup(ptr) strdup(ptr)
#define curlx_strdup(ptr) strdup(ptr)
#endif
#define curlx_malloc(size) malloc(size)
#define curlx_calloc(nbelem,size) calloc(nbelem, size)
#define curlx_realloc(ptr,size) realloc(ptr, size)
#define curlx_free(ptr) free(ptr)
#define curlx_malloc(size) malloc(size)
#define curlx_calloc(nbelem, size) calloc(nbelem, size)
#define curlx_realloc(ptr, size) realloc(ptr, size)
#define curlx_free(ptr) free(ptr)
#endif /* BUILDING_LIBCURL */
#ifdef _WIN32
#ifdef UNICODE
#define curlx_tcsdup(ptr) Curl_wcsdup(ptr)
#define curlx_tcsdup(ptr) Curl_wcsdup(ptr)
#else
#define curlx_tcsdup(ptr) curlx_strdup(ptr)
#define curlx_tcsdup(ptr) curlx_strdup(ptr)
#endif
#endif /* _WIN32 */
@ -1124,8 +1125,8 @@ int getpwuid_r(uid_t uid, struct passwd *pwd, char *buf,
#endif
#if (defined(USE_NGTCP2) && defined(USE_NGHTTP3)) || \
(defined(USE_OPENSSL_QUIC) && defined(USE_NGHTTP3)) || \
defined(USE_QUICHE)
(defined(USE_OPENSSL_QUIC) && defined(USE_NGHTTP3)) || \
defined(USE_QUICHE)
#ifdef CURL_WITH_MULTI_SSL
#error "MultiSSL combined with QUIC is not supported"

4
lib/curl_setup_once.h
View file

@ -263,7 +263,7 @@ typedef unsigned int bit;
#ifdef DEBUGBUILD
#define DEBUGF(x) x
#else
#define DEBUGF(x) do { } while(0)
#define DEBUGF(x) do {} while(0)
#endif
/*
@ -273,7 +273,7 @@ typedef unsigned int bit;
#ifdef DEBUGBUILD
#define DEBUGASSERT(x) assert(x)
#else
#define DEBUGASSERT(x) do { } while(0)
#define DEBUGASSERT(x) do {} while(0)
#endif
/*

1
lib/easy.c
View file

@ -643,7 +643,6 @@ static CURLcode wait_or_timeout(struct Curl_multi *multi, struct events *ev)
}
}
if(!ev->msbump && ev->ms >= 0) {
/* If nothing updated the timeout, we decrease it by the spent time.
* If it was updated, it has the new timeout time stored already.

2
lib/easy_lock.h
View file

@ -59,7 +59,7 @@
#endif
#endif
#endif
#endif /* !__INTEL_COMPILER */
static CURL_INLINE void curl_simple_lock_lock(curl_simple_lock *lock)
{

1
lib/ftp.c
View file

@ -3685,7 +3685,6 @@ static CURLcode ftp_do_more(struct Curl_easy *data, int *completep)
return result;
}
/***********************************************************************
*
* ftp_perform()

1
lib/imap.c
View file

@ -142,7 +142,6 @@ struct IMAP {
BIT(uidvalidity_set);
};
/* Local API functions */
static CURLcode imap_regular_transfer(struct Curl_easy *data,
struct IMAP *imap,

2
lib/mime.c
View file

@ -262,7 +262,6 @@ static char *Curl_basename(char *path)
#define basename(x) Curl_basename(x)
#endif
/* Set readback state. */
static void mimesetstate(struct mime_state *state,
enum mimestate tok, void *ptr)
@ -272,7 +271,6 @@ static void mimesetstate(struct mime_state *state,
state->offset = 0;
}
/* Escape header string into allocated memory. */
static char *escape_string(struct Curl_easy *data,
const char *src, enum mimestrategy strategy)

2
lib/rtsp.c
View file

@ -43,7 +43,6 @@
#include "bufref.h"
#include "curlx/strparse.h"
/* meta key for storing protocol meta at easy handle */
#define CURL_META_RTSP_EASY "meta:proto:rtsp:easy"
/* meta key for storing protocol meta at connection */
@ -72,7 +71,6 @@ struct RTSP {
long CSeq_recv; /* CSeq received */
};
#define RTP_PKT_LENGTH(p) ((((unsigned int)((unsigned char)((p)[2]))) << 8) | \
((unsigned int)((unsigned char)((p)[3]))))

1
lib/smtp.c
View file

@ -1703,7 +1703,6 @@ static CURLcode smtp_regular_transfer(struct Curl_easy *data,
return result;
}
static void smtp_easy_dtor(void *key, size_t klen, void *entry)
{
struct SMTP *smtp = entry;

1
lib/telnet.c
View file

@ -94,7 +94,6 @@
#define CURL_EMPTY 0
#define CURL_OPPOSITE 1
/* meta key for storing protocol meta at easy handle */
#define CURL_META_TELNET_EASY "meta:proto:telnet:easy"

2
lib/tftp.c
View file

@ -143,7 +143,6 @@ struct tftp_conn {
BIT(remote_pinned);
};
/* Forward declarations */
static CURLcode tftp_rx(struct tftp_conn *state, tftp_event_t event);
static CURLcode tftp_tx(struct tftp_conn *state, tftp_event_t event);
@ -162,7 +161,6 @@ static CURLcode tftp_translate_code(tftp_error_t error);
/*
* TFTP protocol handler.
*/
const struct Curl_handler Curl_handler_tftp = {
"tftp", /* scheme */
tftp_setup_connection, /* setup_connection */

14
lib/urldata.h
View file

@ -741,14 +741,14 @@ struct connectdata {
#ifndef CURL_DISABLE_PROXY
#define CURL_CONN_HOST_DISPNAME(c) \
((c)->bits.socksproxy ? (c)->socks_proxy.host.dispname : \
(c)->bits.httpproxy ? (c)->http_proxy.host.dispname : \
(c)->bits.conn_to_host ? (c)->conn_to_host.dispname : \
(c)->host.dispname)
((c)->bits.socksproxy ? (c)->socks_proxy.host.dispname : \
(c)->bits.httpproxy ? (c)->http_proxy.host.dispname : \
(c)->bits.conn_to_host ? (c)->conn_to_host.dispname : \
(c)->host.dispname)
#else
#define CURL_CONN_HOST_DISPNAME(c) \
(c)->bits.conn_to_host ? (c)->conn_to_host.dispname : \
(c)->host.dispname
(c)->bits.conn_to_host ? (c)->conn_to_host.dispname : \
(c)->host.dispname
#endif
/* The end of connectdata. */
@ -1162,7 +1162,7 @@ enum dupstring {
STRING_SSL_CIPHER_LIST, /* list of ciphers to use */
STRING_SSL_CIPHER13_LIST, /* list of TLS 1.3 ciphers to use */
STRING_SSL_CRLFILE, /* CRL file to check certificate */
STRING_SSL_ISSUERCERT, /* issuer cert file to check certificate */
STRING_SSL_ISSUERCERT, /* issuer cert file to check certificate */
STRING_SERVICE_NAME, /* Service name */
#ifndef CURL_DISABLE_PROXY
STRING_CERT_PROXY, /* client certificate filename */

4
lib/version.c
View file

@ -551,9 +551,7 @@ static const struct feat features_table[] = {
{NULL, NULL, 0}
};
static const char *feature_names[sizeof(features_table) /
sizeof(features_table[0])] = {NULL};
static const char *feature_names[CURL_ARRAYSIZE(features_table)] = { NULL };
static curl_version_info_data version_info = {
CURLVERSION_NOW,

1
lib/vquic/vquic.c
View file

@ -54,7 +54,6 @@
#define NW_CHUNK_SIZE (64 * 1024)
#define NW_SEND_CHUNKS 1
int Curl_vquic_init(void)
{
#if defined(USE_NGTCP2) && defined(OPENSSL_QUIC_API2)

1
lib/vssh/libssh.c
View file

@ -282,7 +282,6 @@ static const char *myssh_statename(sshstate state)
#define myssh_statename(x) ""
#endif /* !CURL_DISABLE_VERBOSE_STRINGS */
#define myssh_to(x, y, z) myssh_set_state(x, y, z)
/*

2
lib/vssh/libssh2.c
View file

@ -123,7 +123,6 @@ const struct Curl_handler Curl_handler_scp = {
PROTOPT_NOURLQUERY | PROTOPT_CONN_REUSE
};
/*
* SFTP protocol handler.
*/
@ -353,7 +352,6 @@ static const char *myssh_statename(sshstate state)
#define myssh_statename(x) ""
#endif /* !CURL_DISABLE_VERBOSE_STRINGS */
#define myssh_state(x, y, z) myssh_set_state(x, y, z)
/*

6
lib/vtls/mbedtls.c
View file

@ -229,9 +229,9 @@ static const mbedtls_x509_crt_profile mbedtls_x509_crt_profile_fr = {
1024, /* RSA min key len */
};
/* See https://web.archive.org/web/20200921194007/tls.mbed.org/discussions/
generic/howto-determine-exact-buffer-len-for-mbedtls_pk_write_pubkey_der
*/
/* See:
* https://web.archive.org/web/20200921194007/tls.mbed.org/discussions/generic/howto-determine-exact-buffer-len-for-mbedtls_pk_write_pubkey_der
*/
#define RSA_PUB_DER_MAX_BYTES (38 + 2 * MBEDTLS_MPI_MAX_SIZE)
#define ECP_PUB_DER_MAX_BYTES (30 + 2 * MBEDTLS_ECP_MAX_BYTES)

5
lib/vtls/openssl.c
View file

@ -1443,7 +1443,6 @@ fail:
return 1;
}
static CURLcode client_cert(struct Curl_easy *data,
SSL_CTX* ctx,
char *cert_file,
@ -3629,7 +3628,6 @@ static CURLcode ossl_init_ssl(struct ossl_ctx *octx,
alpns_requested, sess_reuse_cb);
}
static CURLcode ossl_init_method(struct Curl_cfilter *cf,
struct Curl_easy *data,
struct ssl_peer *peer,
@ -3828,7 +3826,7 @@ CURLcode Curl_ossl_ctx_init(struct ossl_ctx *octx,
OpenSSL supports processing "jumbo TLS record" (8 TLS records) in one go
for some algorithms, so match that here.
Experimentation shows that a slightly larger buffer is needed
to avoid short reads.
to avoid short reads.
However using a large buffer (8 packets) actually decreases performance.
4 packets is better.
@ -4669,7 +4667,6 @@ out:
}
#endif /* ! CURL_DISABLE_VERBOSE_STRINGS */
#ifdef USE_APPLE_SECTRUST
struct ossl_certs_ctx {
STACK_OF(X509) *sk;

4
lib/vtls/schannel.c
View file

@ -70,8 +70,8 @@
#define SCH_DEV_SHOWBOOL(x) \
infof(data, "schannel: " #x " %s", (x) ? "TRUE" : "FALSE");
#else
#define SCH_DEV(x) do { } while(0)
#define SCH_DEV_SHOWBOOL(x) do { } while(0)
#define SCH_DEV(x) do {} while(0)
#define SCH_DEV_SHOWBOOL(x) do {} while(0)
#endif
/* Offered by mingw-w64 v8+. MS SDK 7.0A+. */

1
lib/vtls/wolfssl.c
View file

@ -36,7 +36,6 @@
#include <wolfssl/options.h>
#include <wolfssl/version.h>
#if LIBWOLFSSL_VERSION_HEX < 0x03004006 /* wolfSSL 3.4.6 (2015) */
#error "wolfSSL version should be at least 3.4.6"
#endif

1
lib/vtls/x509asn1.c
View file

@ -92,7 +92,6 @@
/* #define CURL_ASN1_CHARACTER_STRING 29 */
#define CURL_ASN1_BMP_STRING 30
#ifdef WANT_EXTRACT_CERTINFO
/* ASN.1 OID table entry. */
struct Curl_OID {

2
lib/ws.c
View file

@ -43,7 +43,6 @@
#include "curlx/strparse.h"
#include "curlx/warnless.h"
/***
RFC 6455 Section 5.2
@ -770,7 +769,6 @@ static const struct Curl_cwtype ws_cw_decode = {
sizeof(struct ws_cw_ctx)
};
static void ws_enc_info(struct ws_encoder *enc, struct Curl_easy *data,
const char *msg)
{