mirror of
https://github.com/curl/curl.git
synced 2026-08-03 10:10:28 +03:00
badwords: check indented lines in source code, fix fallouts
- badwords.pl: add `-a` option to check all lines in source code files. Before this patch indented lines were skipped (to avoid Markdown code fences.) - GHA/checksrc: use `-a` when verifying the source code. - GHA/checksrc: disable `So` and `But` rules for source code. - GHA/checksrc: add docs/examples to the verified sources. - badwords.txt: delete 4 duplicates. - badwords.txt: group and sort contractions. - badwords.txt: allow ` url = `, `DIR`, `<file name`. Closes #19536
This commit is contained in:
parent
8a968095df
commit
2dc71ba8bf
73 changed files with 146 additions and 144 deletions
|
|
@ -148,7 +148,7 @@ CURLcode Curl_vtls_apple_verify(struct Curl_cfilter *cf,
|
|||
* add `kSecRevocationRequirePositiveResponse` to the Apple
|
||||
* Trust policies, it interprets this as it NEEDs a confirmation
|
||||
* of a cert being NOT REVOKED. Which not in general available for
|
||||
* certificates on the internet.
|
||||
* certificates on the Internet.
|
||||
* It seems that applications using this policy are expected to PIN
|
||||
* their certificate public keys or verification will fail.
|
||||
* This does not seem to be what we want here. */
|
||||
|
|
|
|||
|
|
@ -1688,7 +1688,7 @@ static CURLcode client_cert(struct Curl_easy *data,
|
|||
failf(data,
|
||||
"could not load PEM client certificate from %s, " OSSL_PACKAGE
|
||||
" error %s, "
|
||||
"(no key found, wrong pass phrase, or wrong file format?)",
|
||||
"(no key found, wrong passphrase, or wrong file format?)",
|
||||
(cert_blob ? "CURLOPT_SSLCERT_BLOB" : cert_file),
|
||||
ossl_strerror(ERR_get_error(), error_buffer,
|
||||
sizeof(error_buffer)) );
|
||||
|
|
@ -1708,7 +1708,7 @@ static CURLcode client_cert(struct Curl_easy *data,
|
|||
failf(data,
|
||||
"could not load ASN1 client certificate from %s, " OSSL_PACKAGE
|
||||
" error %s, "
|
||||
"(no key found, wrong pass phrase, or wrong file format?)",
|
||||
"(no key found, wrong passphrase, or wrong file format?)",
|
||||
(cert_blob ? "CURLOPT_SSLCERT_BLOB" : cert_file),
|
||||
ossl_strerror(ERR_get_error(), error_buffer,
|
||||
sizeof(error_buffer)) );
|
||||
|
|
@ -5154,7 +5154,7 @@ CURLcode Curl_ossl_check_peer_cert(struct Curl_cfilter *cf,
|
|||
#endif
|
||||
|
||||
if(data->set.ssl.certinfo && !octx->reused_session) {
|
||||
/* asked to gather certificate info. Reused sessions don't have cert
|
||||
/* asked to gather certificate info. Reused sessions do not have cert
|
||||
chains */
|
||||
result = ossl_certchain(data, octx->ssl);
|
||||
if(result)
|
||||
|
|
@ -5684,7 +5684,7 @@ static CURLcode ossl_get_channel_binding(struct Curl_easy *data, int sockindex,
|
|||
|
||||
cert = SSL_get1_peer_certificate(octx->ssl);
|
||||
if(!cert)
|
||||
/* No server certificate, don't do channel binding */
|
||||
/* No server certificate, do not do channel binding */
|
||||
return CURLE_OK;
|
||||
|
||||
if(!OBJ_find_sigid_algs(X509_get_signature_nid(cert), &algo_nid, NULL)) {
|
||||
|
|
|
|||
|
|
@ -1286,7 +1286,7 @@ schannel_connect_step2(struct Curl_cfilter *cf, struct Curl_easy *data)
|
|||
|
||||
/* The socket must be writeable (or a poll error occurred) before we call
|
||||
InitializeSecurityContext to continue processing the received TLS
|
||||
records. This is because that function is not idempotent and we don't
|
||||
records. This is because that function is not idempotent and we do not
|
||||
support partial save/resume sending replies of handshake tokens. */
|
||||
if(!SOCKET_WRITABLE(Curl_conn_cf_get_socket(cf, data), 0)) {
|
||||
SCH_DEV(infof(data, "schannel: handshake waiting for writeable socket"));
|
||||
|
|
@ -1809,7 +1809,7 @@ schannel_recv_renegotiate(struct Curl_cfilter *cf, struct Curl_easy *data,
|
|||
* data needs to be sent then we block for a writeable socket that should
|
||||
* be writeable immediately except for OS resource constraints. For caller
|
||||
* send if handshake data needs to be received then we block for a readable
|
||||
* socket, which could take some time, but it's more likely the user has
|
||||
* socket, which could take some time, but it is more likely the user has
|
||||
* called recv since they had called it prior (only recv can start
|
||||
* renegotiation and probably the user is going to call it again to get
|
||||
* more of their data before calling send).
|
||||
|
|
|
|||
|
|
@ -1423,7 +1423,7 @@ static CURLcode ssl_cf_connect_deferred(struct Curl_cfilter *cf,
|
|||
result = ssl_cf_set_earlydata(cf, data, buf, blen);
|
||||
if(result)
|
||||
return result;
|
||||
/* we buffered any early data we'd like to send. Actually
|
||||
/* we buffered any early data we would like to send. Actually
|
||||
* do the connect now which sends it and performs the handshake. */
|
||||
connssl->earlydata_state = ssl_earlydata_sending;
|
||||
connssl->earlydata_skip = Curl_bufq_len(&connssl->earlydata);
|
||||
|
|
|
|||
|
|
@ -1725,7 +1725,7 @@ static CURLcode wssl_handshake(struct Curl_cfilter *cf,
|
|||
if(ret == WOLFSSL_SUCCESS &&
|
||||
conn_config->verifyhost &&
|
||||
!connssl->peer.sni) {
|
||||
/* we have an IP address as host name. */
|
||||
/* we have an IP address as hostname. */
|
||||
WOLFSSL_X509* cert = wolfSSL_get_peer_certificate(wssl->ssl);
|
||||
if(!cert) {
|
||||
failf(data, "unable to get peer certificate");
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue