From 2b8d63421fbb0474c1b972ec077b41f8f2693a41 Mon Sep 17 00:00:00 2001 From: Viktor Szakats Date: Sat, 12 Jul 2025 11:27:29 +0200 Subject: [PATCH] runner.pm: rename variables to avoid an exception --- .github/scripts/codespell-ignore.txt | 1 - tests/runner.pm | 12 ++++++------ 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/.github/scripts/codespell-ignore.txt b/.github/scripts/codespell-ignore.txt index e3a8643ff9..b6a551f7d8 100644 --- a/.github/scripts/codespell-ignore.txt +++ b/.github/scripts/codespell-ignore.txt @@ -16,7 +16,6 @@ numer PASE perfec pres -rin seh ser strat diff --git a/tests/runner.pm b/tests/runner.pm index e26fcf4f46..a208eba3a2 100644 --- a/tests/runner.pm +++ b/tests/runner.pm @@ -1368,13 +1368,13 @@ sub runnerar { # Called by controller sub runnerar_ready { my ($blocking) = @_; - my $rin = ""; + my $r_in = ""; my %idbyfileno; my $maxfileno=0; my @ready_runners = (); foreach my $p (keys(%controllerr)) { my $fd = fileno($controllerr{$p}); - vec($rin, $fd, 1) = 1; + vec($r_in, $fd, 1) = 1; $idbyfileno{$fd} = $p; # save the runner ID for each pipe fd if($fd > $maxfileno) { $maxfileno = $fd; @@ -1386,14 +1386,14 @@ sub runnerar_ready { # This may be interrupted and return EINTR, but this is ignored and the # caller will need to later call this function again. # TODO: this is relatively slow with hundreds of fds - my $ein = $rin; - if(select(my $rout=$rin, undef, my $eout=$ein, $blocking) >= 1) { + my $e_in = $r_in; + if(select(my $r_out=$r_in, undef, my $e_out=$e_in, $blocking) >= 1) { for my $fd (0..$maxfileno) { # Return an error condition first in case it's both - if(vec($eout, $fd, 1)) { + if(vec($e_out, $fd, 1)) { return (undef, $idbyfileno{$fd}); } - if(vec($rout, $fd, 1)) { + if(vec($r_out, $fd, 1)) { push(@ready_runners, $idbyfileno{$fd}); } }