romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-04-15 00:21:42 +03:00
Code Issues Projects Releases Packages Wiki Activity

vtls_scache: fix race condition

Browse source 
- Lock before counting the cache sessions.

Prior to this change when taking a session a trace command counted the
sessions but not under lock, which caused a race condition.

Reported by: Viktor Szakats

Fixes https://github.com/curl/curl/issues/18806
Closes https://github.com/curl/curl/pull/18813
This commit is contained in:
Jay Satiro 2025-10-02 09:46:36 -04:00
parent 03fe446789
commit 2a25ebe958
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/vtls/vtls_scache.c
View file

@ -902,7 +902,6 @@ CURLcode Curl_ssl_scache_take(struct Curl_cfilter *cf,
peer->age = scache->age; /* set this as used in this age */
}
}
Curl_ssl_scache_unlock(data);
if(s) {
*ps = s;
CURL_TRC_SSLS(data, "took session for %s [proto=0x%x, "
@ -914,6 +913,7 @@ CURLcode Curl_ssl_scache_take(struct Curl_cfilter *cf,
else {
CURL_TRC_SSLS(data, "no cached session for %s", ssl_peer_key);
}
Curl_ssl_scache_unlock(data);
return result;
}