From 2864e995435e71a152a9ae090a72df6833025a01 Mon Sep 17 00:00:00 2001 From: Viktor Szakats Date: Tue, 9 Jun 2026 17:44:05 +0200 Subject: [PATCH] smbserver: update internal id generation for Python 3 Also: - make next id based on highest in list + 1. (was: last id in list + 1) - unfold a line. Spotted by GitHub Code Quality Ref: https://portingguide.readthedocs.io/en/latest/dicts.html?highlight=keys Closes #21937 --- tests/smbserver.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/smbserver.py b/tests/smbserver.py index c3eeb1105c..49c6162463 100755 --- a/tests/smbserver.py +++ b/tests/smbserver.py @@ -212,8 +212,7 @@ class TestSmbServer(imp_smbserver.SMBSERVER): flags2 = recv_packet["Flags2"] ncax_data = imp_smb.SMBNtCreateAndX_Data(flags=flags2, - data=smb_command[ - "Data"]) + data=smb_command["Data"]) requested_file = imp_smbserver.decodeSMBString( flags2, ncax_data["FileName"]) @@ -234,7 +233,7 @@ class TestSmbServer(imp_smbserver.SMBSERVER): if len(conn_data["OpenedFiles"]) == 0: fakefid = 1 else: - fakefid = conn_data["OpenedFiles"].keys()[-1] + 1 + fakefid = max(conn_data["OpenedFiles"].keys()) + 1 resp_params["Fid"] = fakefid resp_params["CreateAction"] = disposition