mirror of
https://github.com/curl/curl.git
synced 2026-08-24 22:43:38 +03:00
metalink: remove
Warning: this will make existing curl command lines that use metalink to stop working. Reasons for removal: 1. We've found several security problems and issues involving the metalink support in curl. The issues are not detailed here. When working on those, it become apparent to the team that several of the problems are due to the system design, metalink library API and what the metalink RFC says. They are very hard to fix on the curl side only. 2. The metalink usage with curl was only very briefly documented and was not following the "normal" curl usage pattern in several ways, making it surprising and non-intuitive which could lead to further security issues. 3. The metalink library was last updated 6 years ago and wasn't so active the years before that either. An unmaintained library means there's a security problem waiting to happen. This is probably reason enough. 4. Metalink requires an XML parsing library, which is complex code (even the smaller alternatives) and to this day often gets security updates. 5. Metalink is not a widely used curl feature. In the 2020 curl user survey, only 1.4% of the responders said that they'd are using it. In 2021 that number was 1.2%. Searching the web also show very few traces of it being used, even with other tools. 6. The torrent format and associated technology clearly won for downloading large files from multiple sources in parallel. Cloes #7176
This commit is contained in:
parent
9cf516adc6
commit
265b14d6b3
48 changed files with 65 additions and 3154 deletions
|
|
@ -1,90 +0,0 @@
|
|||
<testcase>
|
||||
<info>
|
||||
<keywords>
|
||||
Metalink
|
||||
HTTP
|
||||
HTTP GET
|
||||
</keywords>
|
||||
</info>
|
||||
|
||||
#
|
||||
# Server-side
|
||||
<reply>
|
||||
<data nocheck="yes">
|
||||
HTTP/1.1 200 OK
|
||||
Date: Wed, 20 Jun %TESTNUMBER 14:49:00 GMT
|
||||
Server: test-server/fake
|
||||
Content-Length: 46
|
||||
Connection: close
|
||||
Content-Type: text/html
|
||||
Content-Disposition: filename=name%TESTNUMBER; charset=funny; option=strange
|
||||
Funny-head: yesyes
|
||||
|
||||
Some contents delivered from an HTTP resource
|
||||
</data>
|
||||
</reply>
|
||||
|
||||
#
|
||||
# Client-side
|
||||
<client>
|
||||
<server>
|
||||
http
|
||||
</server>
|
||||
<features>
|
||||
file
|
||||
Metalink
|
||||
</features>
|
||||
<name>
|
||||
Metalink local XML file, HTTP resource, without hash
|
||||
</name>
|
||||
<command option="no-output,no-include">
|
||||
--metalink file://%PWD/log/test%TESTNUMBER.metalink
|
||||
</command>
|
||||
# local metalink file written before test command runs
|
||||
<file name="log/test%TESTNUMBER.metalink">
|
||||
<?xml version="1.0" encoding="utf-8"?>
|
||||
<metalink version="3.0" xmlns="http://www.metalinker.org/">
|
||||
<files>
|
||||
<file name="log/download%TESTNUMBER">
|
||||
<verification>
|
||||
</verification>
|
||||
<resources maxconnections="1">
|
||||
<url type="http" preference="90">http://%HOSTIP:%HTTPPORT/%TESTNUMBER</url>
|
||||
</resources>
|
||||
</file>
|
||||
</files>
|
||||
</metalink>
|
||||
</file>
|
||||
<postcheck>
|
||||
perl %SRCDIR/libtest/notexists.pl log/%TESTNUMBER log/name%TESTNUMBER
|
||||
</postcheck>
|
||||
</client>
|
||||
|
||||
#
|
||||
# Verify data after the test has been "shot"
|
||||
<verify>
|
||||
<protocol>
|
||||
GET /%TESTNUMBER HTTP/1.1
|
||||
Host: %HOSTIP:%HTTPPORT
|
||||
User-Agent: curl/%VERSION
|
||||
Accept: */*
|
||||
|
||||
</protocol>
|
||||
<file1 name="log/download%TESTNUMBER">
|
||||
Some contents delivered from an HTTP resource
|
||||
</file1>
|
||||
<file2 name="log/stdout%TESTNUMBER">
|
||||
</file2>
|
||||
<file3 name="log/stderr%TESTNUMBER" mode="text">
|
||||
Metalink: parsing (file://%PWD/log/test%TESTNUMBER.metalink) metalink/XML...
|
||||
Metalink: parsing (file://%PWD/log/test%TESTNUMBER.metalink) WARNING (digest missing)
|
||||
Metalink: fetching (log/download%TESTNUMBER) from (http://%HOSTIP:%HTTPPORT/%TESTNUMBER)...
|
||||
Metalink: fetching (log/download%TESTNUMBER) from (http://%HOSTIP:%HTTPPORT/%TESTNUMBER) OK
|
||||
Metalink: validating (log/download%TESTNUMBER)...
|
||||
Metalink: validating (log/download%TESTNUMBER) FAILED (digest missing)
|
||||
</file3>
|
||||
<stripfile3>
|
||||
$_ = '' if (($_ !~ /^Metalink: /) && ($_ !~ /error/i) && ($_ !~ /warn/i))
|
||||
</stripfile3>
|
||||
</verify>
|
||||
</testcase>
|
||||
Loading…
Add table
Add a link
Reference in a new issue