romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-04-14 22:51:53 +03:00
Code Issues Projects Releases Packages Wiki Activity

curlx: move into to curlx/

Browse source 
Move curlx_ functions into its own subdir.

The idea is to use the curlx_ prefix proper on these functions, and use
these same function names both in tool, lib and test suite source code.
Stop the previous special #define setup for curlx_ names.

The printf defines are now done for the library alone. Tests no longer
use the printf defines. The tool code sets its own defines. The printf
functions are not curlx, they are publicly available.

The strcase defines are not curlx_ functions and should not be used by
tool or server code.

dynbuf, warnless, base64, strparse, timeval, timediff are now proper
curlx functions.

When libcurl is built statically, the functions from the library can be
used as-is. The key is then that the functions must work as-is, without
having to be recompiled for use in tool/tests. This avoids symbol
collisions - when libcurl is built statically, we use those functions
directly when building the tool/tests. When libcurl is shared, we
build/link them separately for the tool/tests.

Assisted-by: Jay Satiro

Closes #17253
This commit is contained in:
Daniel Stenberg 2025-05-07 11:00:59 +02:00
parent 17e13cba62
commit 255aac56f9
No known key found for this signature in database
GPG key ID: 5CC908FDB71E12C2
463 changed files with 4129 additions and 4008 deletions
Download patch file Download diff file Expand all files Collapse all files

32
lib/telnet.c
View file

@ -57,8 +57,8 @@
#include "arpa_telnet.h"
#include "select.h"
#include "strcase.h"
#include "warnless.h"
#include "strparse.h"
#include "curlx/warnless.h"
#include "curlx/strparse.h"
/* The last 3 #include files should be in this order */
#include "curl_printf.h"
@ -208,7 +208,7 @@ CURLcode init_telnet(struct Curl_easy *data)
if(!tn)
return CURLE_OUT_OF_MEMORY;
Curl_dyn_init(&tn->out, 0xffff);
curlx_dyn_init(&tn->out, 0xffff);
data->req.p.telnet = tn; /* make us known */
tn->telrcv_state = CURL_TS_DATA;
@ -866,9 +866,9 @@ static CURLcode check_telnet_options(struct Curl_easy *data)
const char *p = arg;
curl_off_t x = 0;
curl_off_t y = 0;
if(Curl_str_number(&p, &x, 0xffff) ||
Curl_str_single(&p, 'x') ||
Curl_str_number(&p, &y, 0xffff)) {
if(curlx_str_number(&p, &x, 0xffff) ||
curlx_str_single(&p, 'x') ||
curlx_str_number(&p, &y, 0xffff)) {
failf(data, "Syntax error in telnet option: %s", head->data);
result = CURLE_SETOPT_OPTION_SYNTAX;
}
@ -1236,17 +1236,17 @@ static CURLcode send_telnet_data(struct Curl_easy *data,
if(memchr(buffer, CURL_IAC, nread)) {
/* only use the escape buffer when necessary */
Curl_dyn_reset(&tn->out);
curlx_dyn_reset(&tn->out);
for(i = 0; i < (size_t)nread && !result; i++) {
result = Curl_dyn_addn(&tn->out, &buffer[i], 1);
result = curlx_dyn_addn(&tn->out, &buffer[i], 1);
if(!result && ((unsigned char)buffer[i] == CURL_IAC))
/* IAC is FF in hex */
result = Curl_dyn_addn(&tn->out, "\xff", 1);
result = curlx_dyn_addn(&tn->out, "\xff", 1);
}
outlen = Curl_dyn_len(&tn->out);
outbuf = Curl_dyn_uptr(&tn->out);
outlen = curlx_dyn_len(&tn->out);
outbuf = curlx_dyn_uptr(&tn->out);
}
else {
outlen = (size_t)nread;
@ -1286,7 +1286,7 @@ static CURLcode telnet_done(struct Curl_easy *data,
curl_slist_free_all(tn->telnet_vars);
tn->telnet_vars = NULL;
Curl_dyn_free(&tn->out);
curlx_dyn_free(&tn->out);
return CURLE_OK;
}
@ -1497,8 +1497,8 @@ static CURLcode telnet_do(struct Curl_easy *data, bool *done)
}
if(data->set.timeout) {
now = Curl_now();
if(Curl_timediff(now, conn->created) >= data->set.timeout) {
now = curlx_now();
if(curlx_timediff(now, conn->created) >= data->set.timeout) {
failf(data, "Time-out");
result = CURLE_OPERATION_TIMEDOUT;
keepon = FALSE;
@ -1618,8 +1618,8 @@ static CURLcode telnet_do(struct Curl_easy *data, bool *done)
} /* poll switch statement */
if(data->set.timeout) {
now = Curl_now();
if(Curl_timediff(now, conn->created) >= data->set.timeout) {
now = curlx_now();
if(curlx_timediff(now, conn->created) >= data->set.timeout) {
failf(data, "Time-out");
result = CURLE_OPERATION_TIMEDOUT;
keepon = FALSE;