From 208b87744e8ce326e2569c2efd735da43ce74a0b Mon Sep 17 00:00:00 2001 From: Viktor Szakats Date: Fri, 20 Mar 2026 19:00:44 +0100 Subject: [PATCH] GHA/windows: disable `taskkill` in torture jobs As an experiment. Also: - processhelp.pm: log when `taskkill` is force-skipped. Ref: #21035 Follow-up to f450f3801b6b9dff0ea280f5fb4bf28203f7b313 #19897 Follow-up to 2701ac6a4d16a62130dad05be1c484903b8545c7 #19421 Closes #21039 --- .github/workflows/windows.yml | 1 + tests/processhelp.pm | 6 ++++++ 2 files changed, 7 insertions(+) diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml index c2c56c0abf..edd31632c6 100644 --- a/.github/workflows/windows.yml +++ b/.github/workflows/windows.yml @@ -431,6 +431,7 @@ jobs: fi if [[ "${TFLAGS}" = *'-t'* ]]; then TFLAGS+=' !2300' # Leaks memory and file handle via tool_doswin.c / win32_stdin_read_thread() + export CURL_TEST_NO_TASKKILL=1 # experiment to see if it reduces flaky failures fi fi if [ -x "$(cygpath "${SYSTEMROOT}/System32/curl.exe")" ]; then diff --git a/tests/processhelp.pm b/tests/processhelp.pm index 1ff51f339e..299bce0d8a 100644 --- a/tests/processhelp.pm +++ b/tests/processhelp.pm @@ -192,6 +192,9 @@ sub pidterm { print "Executing: '$cmd'\n"; system($cmd); } + else { + print "taskkill disabled via CURL_TEST_NO_TASKKILL.\n"; + } } return; } @@ -240,6 +243,9 @@ sub pidkill { print "Executing: '$cmd'\n"; system($cmd); } + else { + print "taskkill disabled via CURL_TEST_NO_TASKKILL.\n"; + } } return; }