From 1e3c2bec7eb735736755e15a48701f5b2d5b5979 Mon Sep 17 00:00:00 2001 From: Viktor Szakats Date: Sun, 15 Mar 2026 15:07:35 +0100 Subject: [PATCH] GHA/http3-linux: add CI reproducer for `--with-ngtcp2=` regression Configure LibreSSL autotools job with `--with-ngtcp=` instead of adding ngtcp2 to `PKG_CONFIG_PATH`. To test this way of configuration in CI and test for the regression reported in #20889. Turns out this way of configuration isn't affected by the detection issue in this particular case. It also works for other backends except for these two, subject to separate fixes: - BoringSSL fix: https://github.com/ngtcp2/ngtcp2/pull/2070 - GnuTLS fix and BoringSSL workaround: #20920 Follow-up to 666db801963afca671ee5fa83bd2e9ed79fb8886 #20891 Follow-up to 8db0e286b363ad788d6dc0779d605b83c7ed4caf #18189 Follow-up to 99500660af19f89069e71c2251c13963401b3806 #18028 #18022 Closes #20926 --- .github/workflows/http3-linux.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/http3-linux.yml b/.github/workflows/http3-linux.yml index 285843cf19..0b13dcf4d5 100644 --- a/.github/workflows/http3-linux.yml +++ b/.github/workflows/http3-linux.yml @@ -370,10 +370,11 @@ jobs: - name: 'libressl' install_steps: skipall - PKG_CONFIG_PATH: /home/runner/libressl/build/lib/pkgconfig:/home/runner/nghttp3/build/lib/pkgconfig:/home/runner/ngtcp2/build/lib/pkgconfig:/home/runner/nghttp2/build/lib/pkgconfig + # Intentionally using '--with-ngtcp2=' to test this way of configuration, in addition to bare '--with-ngtcp2' + 'PKG_CONFIG_PATH' in other jobs. + PKG_CONFIG_PATH: /home/runner/libressl/build/lib/pkgconfig:/home/runner/nghttp3/build/lib/pkgconfig:/home/runner/nghttp2/build/lib/pkgconfig configure: >- LDFLAGS=-Wl,-rpath,/home/runner/libressl/build/lib - --with-openssl=/home/runner/libressl/build --with-ngtcp2 --enable-ssls-export + --with-openssl=/home/runner/libressl/build --with-ngtcp2=/home/runner/ngtcp2/build --enable-ssls-export --enable-unity - name: 'libressl'