romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-05-30 11:17:30 +03:00
Code Issues Projects Releases Packages Wiki Activity

tool: dump headers even if file is write-only

Browse source 
The fixes in #10079 brought a (seemingly unrelated) change of open mode
from `wb`/`ab` to `wb+`/`ab+` for the headerfile. This makes it no
longer possible to write the header file to e.g. a pipe, like:

    curl -D >(grep ...) file:///dev/null

Which presently results in `Warning: Failed to open /dev/fd/63`

See #10079
Closes #10675
This commit is contained in:
Grisha Levit 2023-03-04 16:32:56 -05:00 • committed by Daniel Stenberg
parent c12e8bfa89
commit 1dd929674e
No known key found for this signature in database
GPG key ID: 5CC908FDB71E12C2
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/tool_operate.c
View file

@ -983,11 +983,11 @@ static CURLcode single_transfer(struct GlobalConfig *global,
* for every transfer.
*/
if(!per->prev || per->prev->config != config) {
newfile = fopen(config->headerfile, "wb+");
newfile = fopen(config->headerfile, "wb");
if(newfile)
fclose(newfile);
}
newfile = fopen(config->headerfile, "ab+");
newfile = fopen(config->headerfile, "ab");
if(!newfile) {
errorf(global, "Failed to open %s\n", config->headerfile);