romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-07-30 01:48:04 +03:00
Code Issues Projects Releases Packages Wiki Activity

mime: remove support "-" stdin pseudo-file name in curl_mime_filedata().

Browse source 
This feature is badly supported in Windows: as a replacement, a caller has
to use curl_mime_data_cb() with fread, fseek and possibly fclose
callbacks to process opened files.

The cli tool and documentation are updated accordingly.

The feature is however kept internally for form API compatibility, with
the known caveats it always had.

As a side effect, stdin size is not determined by the cli tool even if
possible and this results in a chunked transfer encoding. Test 173 is
updated accordingly.
This commit is contained in:
Patrick Monnerat 2017-09-03 14:45:43 +01:00
parent 045b076ae8
commit 1a3f4c1991
7 changed files with 48 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

23
src/tool_formparse.c
View file

@ -347,6 +347,21 @@ static int get_param_part(struct OperationConfig *config, char **str,
return sep & 0xFF;
}
/* Check if file is "-". If so, use a callback to read OUR stdin (to
* workaround Windows DLL file handle caveat).
* Else use curl_mime_filedata(). */
static CURLcode file_or_stdin(curl_mimepart *part, const char *file)
{
CURLcode ret = CURLE_OK;
if(strcmp(file, "-"))
return curl_mime_filedata(part, file);
return curl_mime_data_cb(part, -1, (curl_read_callback) fread,
(curl_seek_callback) fseek, NULL, stdin);
}
/***************************************************************************
*
* formparse()
@ -547,9 +562,9 @@ int formparse(struct OperationConfig *config,
}
/* Setup file in part. */
res = curl_mime_filedata(part, data);
res = file_or_stdin(part, data);
if(res) {
warnf(config->global, "curl_mime_filedata failed!\n");
warnf(config->global, "setting file %s failed!\n", data);
if(res != CURLE_READ_ERROR) {
if(subparts != *mimecurrent)
curl_mime_free(subparts);
@ -619,9 +634,9 @@ int formparse(struct OperationConfig *config,
}
/* Setup file in part. */
res = curl_mime_filedata(part, data);
res = file_or_stdin(part, data);
if(res) {
warnf(config->global, "curl_mime_filedata failed!\n");
warnf(config->global, "setting file %s failed!\n", data);
if(res != CURLE_READ_ERROR) {
Curl_safefree(contents);
return 22;