romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-04-15 02:31:40 +03:00
Code Issues Projects Releases Packages Wiki Activity

tool_getparam: remove two nextarg NULL checks

Browse source 
Because by checking for NULL when the argument can never be NULL, they
mislead the static analyzers into thinking it *can* be NULL and then the
analyzers tend to warn about other places in the code *without* the
check!

Closes #17483
This commit is contained in:
Daniel Stenberg 2025-05-29 10:45:52 +02:00
parent 620401f193
commit 12d13b84fa
No known key found for this signature in database
GPG key ID: 5CC908FDB71E12C2
1 changed files with 9 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

18
src/tool_getparam.c
View file

@ -509,14 +509,13 @@ static void
GetFileAndPassword(const char *nextarg, char **file, char **password)
{
char *certname, *passphrase;
if(nextarg) {
parse_cert_parameter(nextarg, &certname, &passphrase);
free(*file);
*file = certname;
if(passphrase) {
free(*password);
*password = passphrase;
}
/* nextarg is never NULL here */
parse_cert_parameter(nextarg, &certname, &passphrase);
free(*file);
*file = certname;
if(passphrase) {
free(*password);
*password = passphrase;
}
}
@ -1090,7 +1089,8 @@ static ParameterError parse_url(struct GlobalConfig *global,
struct OperationConfig *config,
const char *nextarg)
{
if(nextarg && (nextarg[0] == '@')) {
/* nextarg is never NULL here */
if(nextarg[0] == '@') {
/* read URLs from a file, treat all as -O */
struct dynbuf line;
ParameterError err = PARAM_OK;