romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-07-16 02:17:15 +03:00
Code Issues Projects Releases Packages Wiki Activity

libssh2: print user with verbose flag

Browse source 
This change:

 - Breaks out the existing print out of the LIBSSH2_DEBUG compile-time
   flag
 - Adds (single) quotation marks around the string to better expose the
   actual value
 - Adds a NULL print if not set, mirroring other verbose prints in
   libssh2

Why was this done?

I was trying out the `sftp` option in `curl`, and found myself hitting
an issue where I was not able to get curl to tell me which username it
was using to connect to a host.

With this change, the `User: ` line is printed with `-v`, just like
other SSH verbose prints.

Instead of using the pattern used with *SSH MD5 public key*, where a
ternary is used to print `NULL` on NULL values, it is using a different
branch to add quotes around the string value.

The quotes around the string value are used to better expose to the user
an empty string value, compared to "no-value".

Closes #16430
This commit is contained in:
Samuel Dionne-Riel 2025-02-21 14:24:48 -05:00 • committed by Daniel Stenberg
parent 18c6d5512f
commit 0cd2670afb
No known key found for this signature in database
GPG key ID: 5CC908FDB71E12C2
1 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
lib/vssh/libssh2.c
View file

@ -3167,10 +3167,11 @@ static CURLcode ssh_connect(struct Curl_easy *data, bool *done)
sshc = &conn->proto.sshc;
if(conn->user)
infof(data, "User: '%s'", conn->user);
else
infof(data, "User: NULL");
#ifdef CURL_LIBSSH2_DEBUG
if(conn->user) {
infof(data, "User: %s", conn->user);
}
if(conn->passwd) {
infof(data, "Password: %s", conn->passwd);
}