clang-tidy: drop some redundant conditions reported by misc-redundant-expression

Not enforced due to false positives, and because in cases a redundant
expression (e.g. encapsulated in a macro) may be preferred.

Ref: https://clang.llvm.org/extra/clang-tidy/checks/misc/redundant-expression.html

Closes #20644
This commit is contained in:
Viktor Szakats 2026-02-18 15:14:06 +01:00
parent 078b3031ea
commit 020f48d00c
No known key found for this signature in database
4 changed files with 5 additions and 5 deletions

View file

@ -435,7 +435,7 @@ static int proxy_h2_on_frame_send(nghttp2_session *session,
(void)session;
DEBUGASSERT(data);
if(data && Curl_trc_cf_is_verbose(cf, data)) {
if(Curl_trc_cf_is_verbose(cf, data)) {
char buffer[256];
int len;
len = Curl_nghttp2_fr_print(frame, buffer, sizeof(buffer) - 1);

View file

@ -1126,7 +1126,7 @@ static int on_frame_send(nghttp2_session *session, const nghttp2_frame *frame,
(void)session;
DEBUGASSERT(data);
if(data && Curl_trc_cf_is_verbose(cf, data)) {
if(Curl_trc_cf_is_verbose(cf, data)) {
char buffer[256];
int len;
len = Curl_nghttp2_fr_print(frame, buffer, sizeof(buffer) - 1);

View file

@ -3380,7 +3380,7 @@ static void multi_timeout(struct Curl_multi *multi,
}
#ifdef CURLVERBOSE
if(data && CURL_TRC_TIMER_is_verbose(data)) {
if(CURL_TRC_TIMER_is_verbose(data)) {
struct Curl_llist_node *e = Curl_llist_head(&data->state.timeoutlist);
if(e) {
struct time_node *n = Curl_node_elem(e);
@ -3954,7 +3954,7 @@ struct Curl_easy *Curl_multi_get_easy(struct Curl_multi *multi,
uint32_t mid)
{
struct Curl_easy *data = Curl_uint32_tbl_get(&multi->xfers, mid);
if(data && GOOD_EASY_HANDLE(data))
if(GOOD_EASY_HANDLE(data))
return data;
CURL_TRC_M(multi->admin, "invalid easy handle in xfer table for mid=%u",
mid);

View file

@ -561,7 +561,7 @@ CURLcode Curl_ssl_scache_create(size_t max_peers,
void Curl_ssl_scache_destroy(struct Curl_ssl_scache *scache)
{
if(scache && GOOD_SCACHE(scache)) {
if(GOOD_SCACHE(scache)) {
size_t i;
scache->magic = 0;
for(i = 0; i < scache->peer_count; ++i) {