- use __name__ for logging

- Don't 'try' if you can 'if'

discover_overlay/about_settings.py

@@ -18,7 +18,7 @@ import gi
 import sys
 from .settings import SettingsWindow
 
-log = logging.getLogger("about_settings")
+log = logging.getLogger(__name__)
 
 gi.require_version("Gtk", "3.0")
 # pylint: disable=wrong-import-position,wrong-import-order

discover_overlay/autostart.py

@@ -19,7 +19,7 @@ except ModuleNotFoundError:
     from xdg import XDG_CONFIG_HOME as xdg_config_home
     from xdg import XDG_DATA_HOME as xdg_data_home
 
-log = logging.getLogger("autostart")
+log = logging.getLogger(__name__)
 
 class Autostart:
     """A class to assist auto-start"""

discover_overlay/discord_connector.py

@@ -29,7 +29,7 @@ import calendar
 import websocket
 import requests
 
-log = logging.getLogger("discord_connector")
+log = logging.getLogger(__name__)
 
 class DiscordConnector:
     """

discover_overlay/discover_overlay.py

@@ -40,7 +40,7 @@ try:
 except ModuleNotFoundError:
     from xdg import XDG_CONFIG_HOME as xdg_config_home
 
-log = logging.getLogger("discover_overlay")
+log = logging.getLogger(__name__)
 
 class Discover:
     """Main application class"""

discover_overlay/image_getter.py

@@ -25,7 +25,7 @@ gi.require_version('GdkPixbuf', '2.0')
 # pylint: disable=wrong-import-position
 from gi.repository import Gio, GdkPixbuf  # nopep8
 
-log = logging.getLogger("image_getter")
+log = logging.getLogger(__name__)
 
 class ImageGetter():
     """Older attempt. Not advised as it can't manage anything but PNG. Loads to GDK Pixmap"""

discover_overlay/overlay.py

@@ -30,7 +30,7 @@ try:
 except (ImportError, ValueError):
     pass
 
-log = logging.getLogger("overlay")
+log = logging.getLogger(__name__)
 
 class OverlayWindow(Gtk.Window):
     """

discover_overlay/settings.py

@@ -29,7 +29,7 @@ try:
 except ModuleNotFoundError:
     from xdg import XDG_CONFIG_HOME as xdg_config_home
 
-log = logging.getLogger("settings")
+log = logging.getLogger(__name__)
 
 class SettingsWindow(Gtk.VBox):
     """

discover_overlay/text_overlay.py

@@ -23,7 +23,7 @@ gi.require_version('PangoCairo', '1.0')
 # pylint: disable=wrong-import-position,wrong-import-order
 from gi.repository import Pango, PangoCairo  # nopep8
 
-log = logging.getLogger("text_overlay")
+log = logging.getLogger(__name__)
 
 class TextOverlayWindow(OverlayWindow):
     """Overlay window for voice"""

discover_overlay/text_settings.py

@@ -23,7 +23,7 @@ from gi.repository import Gtk, Gdk  # nopep8
 
 
 GUILD_DEFAULT_VALUE = "0"
-log = logging.getLogger("text_settings")
+log = logging.getLogger(__name__)
 
 class TextSettingsWindow(SettingsWindow):
     """Text setting tab on settings window"""

discover_overlay/voice_overlay.py

@@ -23,7 +23,7 @@ gi.require_version('PangoCairo', '1.0')
 # pylint: disable=wrong-import-position,wrong-import-order
 from gi.repository import Pango, PangoCairo  # nopep8
 
-log = logging.getLogger("voice_overlay")
+log = logging.getLogger(__name__)
 
 class VoiceOverlayWindow(OverlayWindow):
     """Overlay window for voice"""
@@ -188,13 +188,10 @@ class VoiceOverlayWindow(OverlayWindow):
         self.needsredraw = True
 
     def set_guild_ids(self, guild_ids=tuple()):
-        try:
+        if 'connection' in self.discover:
             for _id in guild_ids:
                 if _id not in self.guild_ids:
                     self.discover.connection.req_channels(_id)
-        except AttributeError as _e:
-            log.error(_e)
-            pass
         self.guild_ids = guild_ids
 
     def set_wind_col(self):